Add chpi to known channel list #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1325 +/- ##
=======================================
Coverage 97.47% 97.47%
=======================================
Files 40 40
Lines 8872 8876 +4
=======================================
+ Hits 8648 8652 +4
Misses 224 224 ☔ View full report in Codecov by Sentry. |
|
ready for review :) |
|
Could you please add an entry to the changelog? Then we can merge it. |
|
Done! edit: Apparently I was already part of the author's list - weird, I never contributed here. Maybe that's from my involvement of MNE? |
sappelhoff
reviewed
Oct 22, 2024
|
you DID contribute in 2021! 😄 how the time flies: |
|
Thanks! |
haha, wow. I never actually used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
cHPI was not in the mapping dictionary, I've added it and also added a test.
resolves #1323
Additionally, I found that there are some other channels that are not known/converted and some channel types that are not known to MNE but are still in the mapping dictionary (can they in practice ever arise if they're not in MNE?)
I think we should be able to get an up to date channel list from this code and could use it in the test. However, the module is private, making it harder to access.
Merge checklist
Maintainer, please confirm the following before merging.
If applicable: